Port all lib.rs code into binary
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
reviewed
Oct 5, 2023
src/main.rs
Outdated
| }); | ||
| let processor = TreeProcessor::new(&db_dir)?; | ||
| let (tx, rx) = mpsc::channel::<Vec<CommitBlockInfoV1>>(5); | ||
| processor.run(rx); |
There was a problem hiding this comment.
The returned JoinHandle is not captured nor "awaited" here - how does this work?
There was a problem hiding this comment.
This is the same behavior that we had before, we're just spawning the task inside this function instead. The thing with tokio futures is that they will start executing as soon as they're spawned, await will just wait until that task is done.
Co-authored-by: Tuomas Mäkinen <[email protected]>
zeapoz
force-pushed
the
ref/port-state-tree
branch
from
1c62021 to
21f07d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.